Skip to content

chore(parser): add workaround to make API GW test button work #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2023
Merged

chore(parser): add workaround to make API GW test button work #1971

merged 1 commit into from
Mar 1, 2023

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Mar 1, 2023 •
edited
Loading

Issue number: #1562

Summary

Changes

Please provide a summary of what's being changed

This PR allows parser validation to pass when customers use API Gateway Test button, since it doesn't use an actual IP address for the field source. Instead, it uses a hardcoded string value of "test-invoke-source-ip"

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner March 1, 2023 20:31
@heitorlessa heitorlessa requested review from am29d and removed request for a team March 1, 2023 20:31
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2023
@heitorlessa heitorlessa removed the request for review from am29d March 1, 2023 20:32
@github-actions github-actions bot added the internal Maintenance changes label Mar 1, 2023
@heitorlessa
Copy link
Contributor Author

merging as Leandro and Ruben are both unavailable, and this will make to the patch release I'm about to make.

@heitorlessa heitorlessa added the parser Parser (Pydantic) utility label Mar 1, 2023
@heitorlessa heitorlessa linked an issue Mar 1, 2023 that may be closed by this pull request
Bug: API Gateway Console Test button fails validation with @event_parser because requestContext -> identity -> sourceIp value is not a valid IPv4 or IPv6 network #1562
Closed
@heitorlessa heitorlessa merged commit af7f760 into aws-powertools:develop Mar 1, 2023
@heitorlessa heitorlessa deleted the chore/parser-apigw-model-workaround branch March 1, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal Maintenance changes parser Parser (Pydantic) utility size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
1 participant
@heitorlessa